this post was submitted on 16 Nov 2023
10 points (85.7% liked)

Programming

17398 readers
93 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS
 

In VS I am told this function "does not return a value in all control paths." A bot told me specifically the issue is with this line: else if (letter + key <= 90). It said that if the outcome results in letter + key equally exactly 90 then a value is not returned, but I thought that was covered where '<=' means 'less than or equals.'

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    {
        if (letter + key > 90)
        {
            int overage = letter + key - 90;
            letter = 64 + overage;

            while (letter > 90)
            {
                overage = letter - 90;
                letter += overage;
            }

            return letter;
        }

        else if (letter + key &lt;= 90)
        {
            letter += key;
            return letter;
        }
    }

    else if (isalpha(letter) == false)
    {
        return letter;
    }
top 11 comments
sorted by: hot top controversial new old
[–] DmMacniel@feddit.de 9 points 1 year ago* (last edited 1 year ago) (1 children)

you are missing a returning else block.

[–] milon@lemm.ee 2 points 1 year ago (4 children)

Ah I see. I had a bad habit of using else if statements instead of else statements because I thought else if could be better in seeing the condition it's testing for so it was clearer. I get the logic is actually different now.

[–] towerful@programming.dev 19 points 1 year ago* (last edited 1 year ago)

I'm a fan of early returns.
So

if(isalpha(letter) == false) return letter
if(letter whatever) {
   Do thing
   Return letter
}
if(letter something else) {
   Do something else
   Return letter
}
throw error("unprocessable letter")

I find it lets me mentally walk through all the paths more easily.
And if something gets too complex for this, then I need to break it down into further functions

[–] CameronDev@programming.dev 6 points 1 year ago

I second the early return suggestions, but the other thing you should be aware of is that isalpha() is being evaluated twice unnecessarily. If its cheap and not call frequently, not a real big problem, but it is a waste of cycles. If you want to document the else, you could try:

...
}
else  // isAlpha() == false
{
...

Also, if isAlpha was something that could change between evaluation, such as isTuesday, you are at risk of the first call returning false, and then the second call returning true, which would skip both cases.

[–] DmMacniel@feddit.de 5 points 1 year ago

you are checking the result of a method that returns a boolean (true/false) there is no reason to check for true, else, FILE_NOT_FOUND. you can also forgo equating its return value to something to get a boolean value required for the if statement since its already a boolean value.

e.g.

if (isalpha(letter)) 
{ 
   // ...
} 
else 
{ 
   // ...
}
[–] heeplr@feddit.de 2 points 1 year ago* (last edited 1 year ago)
[–] JakenVeina@lemm.ee 3 points 1 year ago (1 children)

This particular compiler isn't smart enough to recognize that isalpha(letter) == true and isalpha(letter) == false are mutually exclusive conditions. It thinks there's a third scenario that you haven't accounted for.

[–] my_hat_stinks@programming.dev 7 points 1 year ago (2 children)

That's because they're not necessarily mutually exclusive. The function is being called twice so there's no way to guarantee the result will be the same both times without knowing what it does under the hood.

Consider a case where isalpha performs a coin flip, 50% chance each call to return true. The first call returns false so the first condition fails, then the second call returns true so the second condition fails; in 25% of cases neither code block executes.

You could store the result of the first call in a local variable and reuse it if you really wanted to, but the smart solution is to either use if/else properly or switch to early returns instead.

[–] JakenVeina@lemm.ee 2 points 1 year ago

Right, the compiler isn't smart enough to recognize that isalpha() is pure and deterministic.

[–] mrkite@programming.dev 1 points 1 year ago (1 children)

Expect isalpha is part of the standard library not an arbitrary function, a compile should be able to optimize standard calls.

[–] my_hat_stinks@programming.dev 1 points 1 year ago

Compiler optimisations don't apply when you're breaking the rules of the language. It won't compile.