this post was submitted on 16 Nov 2023
10 points (85.7% liked)

Programming

17398 readers
93 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 1 year ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
MaungaHikoi@lemmy.nz
10
Why does a control path not execute in this function? (lemm.ee)
submitted 1 year ago by milon@lemm.ee to c/programming@programming.dev
11 comments fedilink hide all child comments
 

In VS I am told this function "does not return a value in all control paths." A bot told me specifically the issue is with this line: else if (letter + key <= 90). It said that if the outcome results in letter + key equally exactly 90 then a value is not returned, but I thought that was covered where '<=' means 'less than or equals.'

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    {
        if (letter + key > 90)
        {
            int overage = letter + key - 90;
            letter = 64 + overage;

            while (letter > 90)
            {
                overage = letter - 90;
                letter += overage;
            }

            return letter;
        }

        else if (letter + key &lt;= 90)
        {
            letter += key;
            return letter;
        }
    }

    else if (isalpha(letter) == false)
    {
        return letter;
    }
you are viewing a single comment's thread
view the rest of the comments
[–] CameronDev@programming.dev 6 points 1 year ago

I second the early return suggestions, but the other thing you should be aware of is that isalpha() is being evaluated twice unnecessarily. If its cheap and not call frequently, not a real big problem, but it is a waste of cycles. If you want to document the else, you could try:

...
}
else  // isAlpha() == false
{
...

Also, if isAlpha was something that could change between evaluation, such as isTuesday, you are at risk of the first call returning false, and then the second call returning true, which would skip both cases.