Since you were modding Cataclysm, I'm oblidged to say hi. Hi! I'm an author of the original vehicles mod that became core before the DDA. That was hella long ago. https://github.com/gremour/Cataclysm

[–] j4k3@lemmy.world 2 points 2 months ago (1 children)

You legend! Thanks for your contributions.

I'm so nervous about attempting to do pull requests. It is the first time I've ever really considered doing so, and it opens me up to certain vulnerabilities that could have real world consequences.

There are a lot of oddities I don't understand like the mechanism for a terrain connection across z-layers, how the pickaxe mines a rock_large and terrain, the total scope of why a spear or other melee weapon is so fundamentally different from firearms when it comes to attaching mods, or even things like why most items in JSON are so scattered across multiple files for menu namespaces, construction, use, and uncrafting. Anyways, it is daunting to wrap my head around and feel any kind of confidence when I'm entirely self taught and never share my ugly scripts or code. I've probably reinvented so many square wheels that there is no point in sharing, or so it feels some times.

[–] Gremour@lemmy.world 2 points 2 months ago

That's ok. The codebase changed a lot since that time when most of the code was written by original author, Whales. There were no JSONs, all the stuff was hardcoded. It's much larger project nowadays.

Kudos for diving into the code and having interest in the project. Such games really benefit from passionate modders like you.