this post was submitted on 25 Feb 2024
958 points (98.1% liked)

Programmer Humor

32495 readers
268 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] dan@upvote.au 58 points 8 months ago (5 children)

At my workplace, we have a lint rule that reports an error if @nocommit is anywhere in the file, plus a commit hook that blocks all commits with @nocommit anywhere in them. It works well and has saved me a few times.

Works pretty well, except the lint rule and its associated tests have to do something like "@no"+"commit" to avoid triggering it,

[–] wim@lemmy.sdf.org 6 points 8 months ago (3 children)

In a lot of modern work flows this is incompatible with the development pattern.

For example, at my job we have to roll a test release through CI that we then have to deploy to a test kubernetes cluster. You can't even do that if the build is failing because of linting issues.

[–] dan@upvote.au 10 points 8 months ago* (last edited 8 months ago) (2 children)

The test release shouldn't have anything marked with @nocommit though... The idea is that you use it to mark code that is only temporary local debugging code that should never be committed.

[–] Bene7rddso@feddit.de 2 points 8 months ago (1 children)

Are you committing to master? I don't see any reason why you shouldn't commit your debugging code to your own branch. Obviously clean it up before merging

[–] dan@upvote.au 1 points 8 months ago

My workplace uses feature flags rather than feature branches, and a continuous deployment cycle, so we only have one branch.

load more comments (1 replies)