Programming

17392 readers

154 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 1 year ago

MODERATORS

snowe@programming.dev

Ategon@programming.dev

MaungaHikoi@lemmy.nz

215

Other dev won't follow best practices, is this common? (lemmy.world)

submitted 1 year ago by threedragons_19@lemmy.world to c/programming@programming.dev

52 comments fedilink hide all child comments

Hello again, I'm in a situation where the one the senior devs on my team just isn't following best practices we laid out in our internal documentation, nor the generally agreed best practices for react; his code works mind you, but as a a team working on a client piece I'm not super comfortable with something so fragile being passed to the client.

He also doesn't like unit testing and only includes minimal smoke tests, often times he writes his components in ways that will break existing unit tests (there is a caveat that one of the components which is breaking is super fragile; he also led the creation of that one.) But then leaves me to fix it during PR approval.

It's weird because I literally went through most of the same training in company with him on best practices and TDD, but he just seems to ignore it.

I'm not super comfortable approving his work, but its functional and I don't want to hold up sprints,but I'm keenly aware that it could make things really messy whenbwe leave and the client begins to handle it on their own.

What are y'alls thoughts on this, is this sort of thing common?

you are viewing a single comment's thread
view the rest of the comments

[–] pink@programming.dev 28 points 1 year ago (2 children)

It shouldn't be up to another engineer to fix their PRs. They wrote the code, they are responsible for making sure it is in a state to merge. If it's not, request changes and move on to your work.

[–] DAVENP0RT@lemmy.world 7 points 1 year ago

Yeah, we comment in places where we see issues, leave tasks, and just mark the PR as "needs work." I ain't touching code in a branch that's not owned by me.

[–] Ismay@programming.dev 5 points 1 year ago

Soooo much. It's the biggest of red flags to have to fix other's reviews.

Maybe take it up with managment. Those kind of profile are a hinder for every other devs that are working with them