this post was submitted on 01 Aug 2023
215 points (98.6% liked)

Programming

17378 readers
316 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 1 year ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
MaungaHikoi@lemmy.nz
215
Other dev won't follow best practices, is this common? (lemmy.world)
submitted 1 year ago by threedragons_19@lemmy.world to c/programming@programming.dev
52 comments fedilink hide all child comments
 

Hello again, I'm in a situation where the one the senior devs on my team just isn't following best practices we laid out in our internal documentation, nor the generally agreed best practices for react; his code works mind you, but as a a team working on a client piece I'm not super comfortable with something so fragile being passed to the client.

He also doesn't like unit testing and only includes minimal smoke tests, often times he writes his components in ways that will break existing unit tests (there is a caveat that one of the components which is breaking is super fragile; he also led the creation of that one.) But then leaves me to fix it during PR approval.

It's weird because I literally went through most of the same training in company with him on best practices and TDD, but he just seems to ignore it.

I'm not super comfortable approving his work, but its functional and I don't want to hold up sprints,but I'm keenly aware that it could make things really messy whenbwe leave and the client begins to handle it on their own.

What are y'alls thoughts on this, is this sort of thing common?

you are viewing a single comment's thread
view the rest of the comments
[–] nitefox@lemmy.world 16 points 1 year ago (1 children)

Last point is SO painful… I have a coworker that writes so much shitty code OR it straight up doesn’t work… he once submitted a PR that didn’t work when used! Like, I just started the thing and it was utterly broken - both the implementation and the design.

More so, some of his PRs are a giant nightmare of over engineered crap that he, at some point, doesn’t even understand.

Worst of all, he gets angry at me for pointing out that either they don’t work or they are a shitty, complex, mess

Honestly, at some point I started approving his PR and calling it a day; oh we don’t have tests cause reasons, I tried to use TS too but since my boss finds it too complicated we are not using it again for new projects… funny

[–] BeepStreet@lemmy.world 2 points 1 year ago (1 children)

This thread makes me so grateful for working with competent people.

[–] nitefox@lemmy.world 2 points 1 year ago

just yesterday I had to drop a lot of his commits cause they broke some core functionality lol