this post was submitted on 09 Oct 2023
12 points (92.9% liked)
Voyager
5590 readers
57 users here now
The official lemmy community for Voyager, an open source, mobile-first client for lemmy.
Rules
- Be nice.
- lemmy.world instance policy
Sponsor development! π
π
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Design 3 would be consistent with but not with
Also it brings to fore a wider debate. Should that button denote the current status or should it denote the action that will happen on pressing the button.
A favourite is not a subscription, right? Although, I've got to agree with you that a consistent style across favourites and subscriptions would be nice
No they aren't the same. I just thought the design would be more consistent as both of them are options living outside the ellipsis menu.
Also I edited my comment above. Care to weigh in on the discussion thereΒΏ?
Reading the Apple Human Interface Guideline, it states the following:
So Design 1 lays closest to best practice. Regarding the ellipsis menu, I'm not sure what to do there. I'd really like a consistent approach, but a stroke-and-filled state might lead to more confusion than what's there currently. I'm all in on your Design 1 right now.
It is not my design. I just gave some inputs. All credits for the design and the pull request go to https://github.com/sharunkumar