this post was submitted on 16 May 2024
76 points (98.7% liked)
Programming
17534 readers
63 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Out of curiousity, whats your success rate?
I dont think there is anything wrong with that, as long as you are setting the expectations right. In some ways, it takes the load off the maintainer, because they dont necessarily have to "fix" your code, they can just rewrite from scratch using your code as inspiration.
Not high. It tends to result in one of a few things.
They take the fix as offered. Probably it's a smaller quiet project where the number of PRs is small. That, or very well run.
It remains forever open and gets lost in the masses of other out of date PRs. Maybe a bot comes along and closes it as stale. Biggest group, and these ones just tell me that I've got very little chance of getting the maintainer's attention. I can see that 100s of others have experienced the same fate.
Somebody else finds it useful and adopts it, fighting for it to go in. Sometimes that someone is the maintainer. As you say, it can be inspiration for a rewrite of my contribution. That's fine by me. Whatever works.
The maintainer makes a bunch of rework demands leading to rejection, or it gets rejected straight off. "My way or the highway" is always going to be highway. I offered a small piece of help, and if it's not wanted I'll happily go away.
Maybe 20% get in, but it depends on so many things.