this post was submitted on 18 Nov 2023
7 points (81.8% liked)

Programming

17398 readers
151 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS
 

This is in C language. When I call rotate() in main, the function returns false for isalpha() even though the string entered for plaintext uses alphabetic characters. Perhaps it's identifying an alphabetic character by its ASCII value ('A' = 65)? I tried to test that out and used (char) with the letter variable in rotate() but it didn't change anything.

PORTION OF MAIN

string plaintext = get_string("plaintext:  ");

    int length = strlen(plaintext);
    char ciphertext[length];

    for (int i = 0; i < length; i++)
    {
        ciphertext[i] = rotate(plaintext[i], key);
    }

ROTATE FUNCTION

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    { ...
you are viewing a single comment's thread
view the rest of the comments
[–] jjagaimo@lemmy.ca 16 points 1 year ago* (last edited 11 months ago) (4 children)

isalpha documentation:

Return value

Non-zero value if the character is an alphabetic character, zero otherwise.

You should be either checking for not equal to 0 instead of true, as its not necessarily guaranteed to be 1 ~= true, or removing the comparison entirely

Also make sure that your loop condition is < and not "& lt" without the space unless that's a weird formatting issue

For more information, make sure to check the documentation for the standard library functions

[–] pHr34kY@lemmy.world 16 points 1 year ago (1 children)

I would drop the "== true" entirely. C will evaluate any nonzero int as true in an "if" statement.

[–] milon@lemm.ee 2 points 1 year ago
load more comments (2 replies)